-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Unit Level Epub Export #1977
base: master
Are you sure you want to change the base?
Conversation
👍 for your first pull request (PR). Adding some suggestion for this PR: VIEWS/URLS
HTML TEMPLATES:
|
</a> | ||
</li> | ||
</li> | ||
{% endcomment %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this code is not needed, remove it.
If needed in near future, add developers note/comments in it.
<li> | ||
<a href="{% url 'course_pages' group_name %}" {% if title == 'course_pages' or title == 'create_course_pages' %}class="selected"{% endif %}><i class="fi-page-filled "></i> {% trans "Activities" %}</a> | ||
</li> | ||
<li> | ||
<a href="{% url 'asset_list' group_name %}" {% if title == 'asset_list' or title == 'asset_detail' or title == 'asset_content_detail'%}class="selected"{% endif %}><i class="fi-folder-lock"></i> {%trans "Assets" %}</a> | ||
</li> | ||
{% if group_object.agency_type != 'School' and "Author" not in group_object_member_of_names_list %} | ||
{% if group_object.agency_type != 'School' %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While making changes in any of the logical conditions, test it with following use users:
- Anonymous
- Normal
- Group Admin
- Super
@@ -62,6 +62,7 @@ | |||
url(r'^save_metadata', 'save_metadata', name='save_metadata'), | |||
url(r'^save_interactions', 'save_interactions', name='save_interactions'), | |||
url(r'^export_to_epub/(?P<node_id>[\w-]+)', 'export_to_epub', name='export_to_epub'), | |||
url(r'^export_unit_to_epub','export_unit_to_epub',name='export_unit_to_epub'),#Added by Gargi Balasubramaniam |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessary because git keeps details for each and every line:
- creator
- timestamp
- commit no
- commit msg
pass | ||
return HttpResponseRedirect(reverse('unit_detail', kwargs={'group_id': group_id})) | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try to use the existing method and make it more versatile. Method behavior should be decided by args.
Have also committed changes for adding 2 docs- Export_moodle and Epub_issues(for script issues which cause epub validity issues). |
@SheetalKashid please test this and let me know the test results. This is an important and useful feature, so should be merged in the master. |
Description:
Added feature for exporting a single unit into epub format.
By- Xchange Group BITS Pilani Goa